Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F 1837 handle cancel projects in power boosting #731

Merged
merged 3 commits into from
Nov 22, 2022
Merged

F 1837 handle cancel projects in power boosting #731

merged 3 commits into from
Nov 22, 2022

Conversation

mohammadranjbarz
Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz marked this pull request as ready for review November 21, 2022 13:49
CarlosQ96
CarlosQ96 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Mohammad! you can merge this one.

I see our graphql query has default values for "Take Argument" so we don't worry about someone fetching too many powerboostings from the findPowerBoostings function.

@mohammadranjbarz mohammadranjbarz merged commit 36051a4 into staging Nov 22, 2022
@aminlatifi aminlatifi deleted the f_1837_handle_cancel_projects_in_power_boosting branch March 9, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammadranjbarz @CarlosQ96